Update nginx access & error log metric sources to only report metrics that are available #424
+166
−950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that are available instead of returning zero for metric that are missing.
dhurley
requested review from
oliveromahony,
Dean-Coakley,
craigell and
aphralG
✅ Deploy Preview for agent-public-docs canceled.
|
dhurley
added
bug
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
==========================================
- Coverage 67.57% 67.48% -0.10%
==========================================
Files 113 113
Lines 12766 12737 -29
==========================================
- Hits 8627 8595 -32
- Misses 3569 3571 +2
- Partials 570 571 +1
☔ View full report in Codecov by Sentry. |
aphralG
approved these changes
Aug 8, 2023
craigell
approved these changes
Aug 8, 2023
craigell
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update nginx access & error log metric sources to only report metrics that are available instead of returning zero for metrics that are missing.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)